1

Resolved

Convert PlayerCollection and Player to use SendRequestSync

description

This will be done because this method may prove to be more efficient than parsing 64 players every 5 seconds.
 
For PlayerCollection, here's what will use SendRequestSync, off the top of my head:
 
Data will no longer be cached. Although faster, most of the operations will require getting only one Player (client.Players["name"]), which will still be quick.
RconClient.Players will be updated before the Connected and LoggedOn events are sent.
 
 
For Player:
 
Most requests will check for OK and return true on success.

comments

Timiz0r wrote Nov 18, 2011 at 3:10 AM

This is also related to a bug where kills and deaths, for a time between playerinfo updates, can be incorrect because defibs aren't taken into account when kills are parsed.

wrote Nov 18, 2011 at 3:29 PM

Timiz0r wrote Nov 18, 2011 at 11:02 PM

This has been implemented as of changeset 5618. Be sure to read over the notes, as there are some very important changes, mainly the renaming of SendRequest methods.

Since there are surely bugs, I'll keep this open.

wrote Nov 20, 2011 at 8:39 PM

wrote Nov 20, 2011 at 10:52 PM

wrote Feb 13, 2013 at 6:23 PM

wrote May 15, 2013 at 5:09 AM

wrote May 15, 2013 at 5:09 AM

wrote Jun 12, 2013 at 2:02 AM